Allow syncing from the base state of 0. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0 is the state you get when no entities have been created for a specific class yet. If you then add an entity, the state will be '1'. getFooUpdates with a sinceState of 0 should be able to calculate the changes for you. 0-0 is also valid for complex states.
| @@ -158,7 +158,7 @@ sub ix_get_updates ($self, $ctx, $arg = {}) { | |||
|
|
|||
| if ($statecmp->is_resync) { | |||
| $ctx->error(cannotCalculateChanges => { | |||
| description => "client cache must be reconstucted" | |||
| description => "client cache must be reconstructed" | |||
There was a problem hiding this comment.
This is where I saw the weird jcmp_deeply() failure using re('...'). Wasn't until later I realized it was because I had the correct "reconstructed" in the re() and the error actually didn't match...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 is the state you get when no entities have been created for a specific class
yet. If you then add an entity, the state will be '1'. getFooUpdates with a
sinceState of 0 should be able to calculate the changes for you.
0-0 is also valid for complex states.