Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

per-method account ids #37

Closed
wants to merge 12 commits into from
Closed

per-method account ids #37

wants to merge 12 commits into from

Conversation

rjbs
Copy link
Member

@rjbs rjbs commented Oct 19, 2016

  • datasets are now accounts
  • primary context no longer has a single datasetid/accountid
  • Context::WithAccount is generated as needed
  • each method call in a request can have an explicit (or implicit) accountid
  • there can be multiple kinds of account

@wolfsage
Copy link
Contributor

+1

@rjbs
move datasets from Context into Context::WithDataset
84eba1c
@rjbs
Context now has a collection of DatasetStates
31a4a39 
They are not accessed directly through context, but through
Context::WithDataset.  Context caches them so they can still be
saved at the end of a transaction.
@rjbs
is_system has to be delegated back to context root
ce0a743
@rjbs
DatasetState has its own datasetId
e63df1c 
It has to do this because a context no longer has a datasetId
to which to defer.
@rjbs
rclasses must declare their dataset type; then use it
217e7a0 
This way, dataset contexts can be established just in time, and
an Ix system can support entity types with multiple dataset types
as their collections.

This does mean, though, that you will not have one entity that
can appear in more than one type of collection.
@rjbs
Bakesale: set up dataset contexts for testing
11f7604
@rjbs
Bakesale: add dataset types to rclasses
bbdac72
@rjbs
use system context and explicit accountId in processor tests
a10db5e
@rjbs
big rename: datasets are now accounts
be655fb
@rjbs
do not weaken withaccount->root relation
82b5c30 
This blows up when you do:

  my $ctx = acquire_ctx;
  $ctx = $ctx->with_account(...);

...which is useful in testing.  The thing that should be
weak is the cache from root to leaf.
@rjbs
proxy some more methods to root context to ease transition
6a07590
@rjbs
let us use ctx-with-account for process_request
4598d04 
we do not use handles because we want to use $ctx_with_acct as the
invocant so that it is what gets passed into the method calls!
@rjbs
Copy link
Member Author

rjbs commented Oct 24, 2016

merged

@rjbs rjbs closed this Oct 24, 2016
@rjbs rjbs deleted the dataset-mk2 branch August 22, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjbs @wolfsage