-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Mute Button #172
Feature: Mute Button #172
Conversation
Pock/Preferences/Preferences.swift
Outdated
@@ -90,4 +90,5 @@ extension Defaults.Keys { | |||
static let shouldShowBrightnessUpItem = Defaults.Key<Bool>("shouldShowBrightnessUpItem", default: true) | |||
static let shouldShowVolumeDownItem = Defaults.Key<Bool>("shouldShowVolumeDownItem", default: true) | |||
static let shouldShowVolumeUpItem = Defaults.Key<Bool>("shouldShowVolumeUpItem", default: true) | |||
static let shouldShowToggleMuteItem = Defaults.Key<Bool>("shouldShowToggleMuteItem", default: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to have this option false
by default.
case is CCVolumeUpItem, is CCVolumeDownItem: | ||
slideableController?.set(downItem: volumeItems.first, upItem: volumeItems.last) | ||
case is CCVolumeUpItem, is CCVolumeDownItem, is CCToggleMuteItem: | ||
slideableController?.set(downItem: CCVolumeUpItem(parentWidget: self), upItem: CCVolumeDownItem(parentWidget: self)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downItem
should be CCVolumeDownItem
and upItem
should be CCVolumeUpItem
🌚
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed now🦄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments for some little things I think should be addressed before I can merge this excellent PR 👍
name: Pull request
about: Create a pull request to contribute in making Pock amazing!
title: ''
labels: ''
assignees: ''
Describe the Pull request
volumeItems
with new copies of each buttonsScreenshots
Fixes
A comma-separated list of issues that can be closed with this PR.
[e.g. #1, #2, #3 (*required)]
#155
Pull request type
Keep only the option that better matches your pull request.
Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so I can reproduce.
Please, remember to fill the
Test Configuration
section with requested details.Test Configuration:
Checklist
Use this list to keep track of your progress: