Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize app expose settings #229

Merged
merged 4 commits into from
Sep 30, 2019

Conversation

rogerluan
Copy link
Contributor

@rogerluan rogerluan commented Sep 5, 2019

Describe the Pull request
This PR replaces the app exposé boolean settings that weren't ideal, with a dropdown menu that lets you choose between "always" show the app exposé, "never", or "if needed", which shows if there's more than 1 window.

By the way I also improved the autolayout a little bit. It was kinda messy imho 😅

Screenshots

image

image

Fixes
#206

Pull request type
Keep only the option that better matches your pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Tested?

I did test myself all the 3 behaviors. Manual/exploratory test, no unit tests.

Test Configuration:

image

image

Checklist
Use this list to keep track of your progress:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

No tests were written, as there're no related tests to similar parts of the app either 🤔

@rogerluan
Copy link
Contributor Author

@pigigaldi can we get this merged and released? :)

@pigigaldi pigigaldi merged commit 477fc38 into pock:master Sep 30, 2019
@rogerluan rogerluan deleted the customize-app-expose-settings branch September 30, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants