Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added padding between avatar and titles in toolbar #983 #985

Merged
merged 5 commits into from
Feb 29, 2016

Conversation

kubaspatny
Copy link
Contributor

Fixing #983, where there was previously no space between the icon and titles.

Added 8dp padding between the avatar and the titles in Toolbar.

Previously:

before

Now:

now

@ZacSweers
Copy link
Contributor

One nit, rest looks good!

@kubaspatny
Copy link
Contributor Author

Oh right, didn't see that. I will revert it and update tomorrow, thanks!

@kubaspatny
Copy link
Contributor Author

The problem was actually that material dialogs resolved the new Support Library version 23.2.0, which started using vector resources and removed the abc_ic_menu_share_mtrl_alpha resource, replaced by vector resource abc_ic_menu_share_material.

More info:
http://android-developers.blogspot.cz/2016/02/android-support-library-232.html
http://stackoverflow.com/questions/35628572/update-support-library-23-2-0-build-bug/35628668

ZacSweers added a commit that referenced this pull request Feb 29, 2016
Added padding between avatar and titles in toolbar #983
@ZacSweers ZacSweers merged commit 64bf883 into pockethub:master Feb 29, 2016
@ZacSweers
Copy link
Contributor

Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants