Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional release fixes & documentation #1259

Merged
merged 14 commits into from
Jun 19, 2023
Merged

Conversation

franz
Copy link
Contributor

@franz franz commented Jun 15, 2023

No description provided.

@franz franz marked this pull request as ready for review June 15, 2023 12:06
Copy link
Member

@pjaaskel pjaaskel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some small change suggestions to the release notes. Let's make this a standard format in the future releases instead of the CHANGES.

doc/notes_4_0.rst Outdated Show resolved Hide resolved
doc/notes_4_0.rst Outdated Show resolved Hide resolved
doc/notes_4_0.rst Outdated Show resolved Hide resolved
doc/notes_4_0.rst Outdated Show resolved Hide resolved
doc/notes_4_0.rst Outdated Show resolved Hide resolved
doc/sphinx/source/faq.rst Outdated Show resolved Hide resolved
doc/sphinx/source/kernel_compiler.rst Outdated Show resolved Hide resolved
doc/sphinx/source/kernel_compiler.rst Outdated Show resolved Hide resolved
doc/sphinx/source/kernel_compiler.rst Outdated Show resolved Hide resolved
doc/sphinx/source/kernel_compiler.rst Outdated Show resolved Hide resolved
remove docker/PHSA
remove docker/RHEL
remove docker/TCE
update docker/Ubuntu
…d twice

Both calls increased the refcount, and there is only one release per ndrange
command, so this caused dlcache to never release kernels, which caused bug pocl#1257.

fixes to call it once & changes the refcount logic in pocl_check_kernel_dlhandle_cache().
franz and others added 2 commits June 16, 2023 17:02
Co-authored-by: Pekka Jääskeläinen <pekka.jaaskelainen@tuni.fi>
Co-authored-by: Pekka Jääskeläinen <pekka.jaaskelainen@tuni.fi>
doc/notes_4_0.rst Outdated Show resolved Hide resolved
@franz franz merged commit e9fbd01 into pocl:release_4_0 Jun 19, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants