Various features, fixes and hacks to make oneAPI-samples/Libraries/MPI/jacobian_solver SYCL run on PoCL-CPU and PoCL-R #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, just minor nitpicks.
|
|
BTW i have pushed a commit to revert the Asan/Tsan GH runners |
Yes to both. We could add this test to the microsuite as it's quite fast. |
...around the functional changes.
For example, setting the vendor id to be 32902 (0x8086) and setting the driver version using **POCL_DRIVER_VER_OVERRIDE** to "2023.16.7.0.21_160000" (or such) can be used to convince binary-distributed DPC++ compilers to compile and run SYCL programs on the PoCL-CPU driver.
GDB seems to fail to load symbols from .so files which have longer pathnames than 511, thus made the directory length even shorter. Long directory names are produced a lot with C++/SYCL templated kernel/function names.
Since the detection doesn't require llvm-spirv and the remote can support compiling from SPIR-Vs, we should not enable the runtime check only when the client has LLVM-SPIRV installed and enaled. This allows offloading SPIR-Vs from remote-only client builds.
Seems llvm-spirv fails to recompile its own output if the result contained unknown debug MD (likely produced with newer LLVM-SPIRV/LLVM). Strip the debug symbols off for now to circumvent the problem.
Passing '--staged' is useful for formatting newly added files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...via the binary-packaged oneAPI DPC++. Pls check the commits.