Minor bugfixes #601
Merged
Minor bugfixes #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a workaround for an OpenCL bug in LLVM 3.3
Thish should be a check for compiler files, not POCL_DEBUG.
This fails with the additional asserts from previous commit. Also it's just wrong :)
When used with env variable ASAN_OPTIONS=halt_on_error=0, this should enable ASAN builds to continue after first error - unlike the default which is to exit after first error.
Simplifies printf.c to not require math.h, which was conflicting with pocl-types.h in case cl_khr_fp64 was disabled. Also fixes CMake variable ENABLE_FP64 to properly disable doubles. Pocl now builds with -DENABLE_FP64=OFF on 32bit ARM.
due to how the test is written, TSan will inevitably complain.
(float)(double literal) complains when cl_khr_fp64 is disabled
LL_PREPEND(head, item) changes the head (env_cache) on every call, which conflicts with other threads calling find_env() with env_cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of various small issues fixed