Do not expose complete history list, make the history accessible via …

…index - see issue 2
pocmo · Mar 11, 2010 · 733ecd7 · 733ecd7
1 parent 14ca3e0
commit 733ecd7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/src/org/yaaic/adapter/MessageListAdapter.java b/src/org/yaaic/adapter/MessageListAdapter.java
@@ -61,8 +61,8 @@ public MessageListAdapter(Conversation conversation, Context context)
 			messages.add(header.renderTextView(context));
 		}
 
-		for (Message message : conversation.getHistory()) {
-			messages.add(message.renderTextView(context));
+		for (int i = 0; i < conversation.getHistorySize(); i++) {
+			messages.add(conversation.getHistoryMessage(i).renderTextView(context));
 		}
 
 		// XXX: We don't want to clear the buffer, we want to add only

diff --git a/src/org/yaaic/model/Conversation.java b/src/org/yaaic/model/Conversation.java
@@ -86,13 +86,22 @@ public void addMessage(Message message)
 	}
 
 	/**
-	 * Get channel history
+	 * Get size of the current history
+	 */
+	public int getHistorySize()
+	{
+		return history.size();
+	}
+
+	/**
+	 * Get message of the history at the given position
 	 * 
-	 * @return
+	 * @param position
+	 * @return The message at the given position
 	 */
-	public List<Message> getHistory()
+	public Message getHistoryMessage(int position)
 	{
-		return history;
+		return history.get(position);
 	}
 
 	/**