Skip to content

Commit

Permalink
Always set thread names on POSIX platforms (#3384)
Browse files Browse the repository at this point in the history
* chore: gitignore vim .swp files

* feat(POSIX): Always set thread names.

I'm not sure about the original intent to hide it under a DEBUG macro.

Naming the threads in release mode makes it easier to see runtime
application and know which thread pool uses how many threads and what
their names are. Firefox, Chromium and many other apps do this on Linux.
  • Loading branch information
Arun Chandrasekaran committed Jul 7, 2022
1 parent 674446d commit 0af9524
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
7 changes: 7 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,10 @@ cmake-build/
*.bak
stage/
releases/

# vim #
#######
*.orig
*.swp
*.vim
tags
8 changes: 0 additions & 8 deletions Foundation/src/Thread_POSIX.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ namespace
#endif


#if defined(POCO_POSIX_DEBUGGER_THREAD_NAMES)


namespace {
void setThreadName(pthread_t thread, const std::string& threadName)
{
Expand All @@ -83,9 +80,6 @@ void setThreadName(pthread_t thread, const std::string& threadName)
}


#endif


namespace Poco {


Expand Down Expand Up @@ -357,9 +351,7 @@ void* ThreadImpl::runnableEntry(void* pThread)
#endif

ThreadImpl* pThreadImpl = reinterpret_cast<ThreadImpl*>(pThread);
#if defined(POCO_POSIX_DEBUGGER_THREAD_NAMES)
setThreadName(pThreadImpl->_pData->thread, reinterpret_cast<Thread*>(pThread)->getName());
#endif
AutoPtr<ThreadData> pData = pThreadImpl->_pData;
try
{
Expand Down

0 comments on commit 0af9524

Please sign in to comment.