Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name collision when compiling a Poco-based Cocoa app in Xcode #1693

Closed
jayfuerstenberg opened this issue Apr 17, 2017 · 2 comments
Closed

Name collision when compiling a Poco-based Cocoa app in Xcode #1693

jayfuerstenberg opened this issue Apr 17, 2017 · 2 comments
Assignees
@obiltschnig @aleks-f
Labels
duplicate platform_specific

Comments

@jayfuerstenberg
Copy link

jayfuerstenberg commented Apr 17, 2017 •
edited

The NumericString.h file in Poco 1.7.8 has a private method Ptr::check which conflicts with macOS 10.12's check macro (in AssertMacros.h - line 1291) and this thwarts the compilation of Cocoa apps.

Renaming the Ptr::check method (ex: isInRange) or surrounding the class with #undef check + #define check appears to resolve the issue.

  • OS: macOS 10.12.2
  • IDE: Xcode 8.3
  • Poco Version: 1.7.8
  • Target SDK: OS X 10.8

error-location
macos-check
@jacobsologub
Copy link
Contributor

Still an issue as of poco-1.8.1

jacobsologub added a commit to jacobsologub/poco that referenced this issue Jan 16, 2018
@jacobsologub
Fixing NumericString#check function name conflict with check macro …
060c739 
…on macosx10.12.

pocoproject#1451
pocoproject#1693
@jacobsologub jacobsologub mentioned this issue Jan 16, 2018
Merged
jacobsologub added a commit to jacobsologub/poco that referenced this issue Jan 16, 2018
@jacobsologub
Fixing NumericString#check function name conflict with check macro …
c0c1340 
…on macosx10.12.

pocoproject#1451
pocoproject#1693
aleks-f pushed a commit that referenced this issue Jan 17, 2018
@jacobsologub @aleks-f
Fixing NumericString#check function name conflict with check macro …
7726d02 
…on macosx10.12. (#2096)

#1451
#1693
@aleks-f aleks-f self-assigned this Jan 17, 2018
@aleks-f aleks-f added the fixed label Jan 17, 2018
@aleks-f aleks-f added this to the Release 1.8.2 milestone Jan 17, 2018
@aleks-f
Copy link
Member

aleks-f commented Jan 17, 2018

@obiltschnig fixed only in develop, duplicate #1451

@aleks-f aleks-f closed this as completed Jan 17, 2018
aleks-f pushed a commit that referenced this issue Feb 2, 2018
@jacobsologub
Fixing NumericString#check function name conflict with check macro …
6fa4fda 
…on macosx10.12. (#2096)

#1451
#1693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obiltschnig obiltschnig

@aleks-f aleks-f

Labels
duplicate platform_specific
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@obiltschnig @jacobsologub @jayfuerstenberg @aleks-f