Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSIX Thread::sleep() poor performance #3703

Closed
aleks-f opened this issue Jul 20, 2022 · 2 comments · Fixed by #3705
Closed

POSIX Thread::sleep() poor performance #3703

aleks-f opened this issue Jul 20, 2022 · 2 comments · Fixed by #3705

Comments

@aleks-f
Copy link
Member

aleks-f commented Jul 20, 2022

Should be replaced with std::this_thread::sleep_for

@aleks-f aleks-f added this to the Release 1.13.0 milestone Jul 20, 2022
@aleks-f aleks-f self-assigned this Jul 20, 2022
@aleks-f aleks-f linked a pull request Jul 21, 2022 that will close this issue
aleks-f added a commit that referenced this issue Jul 26, 2022
* fix(Thread_POSIX): sleep() poor performance #3703

* chore(vscode): add file associations

* fix(TaskManager): waits for all threads in the ThreadPool #3704

* fix(Thread): call std::this_thread::sleep_for() to sleep #3703

* fix(PollSet): wakeup fd is never read #3708

* feat(Thread): Add Thread::set/getAffinity() #3709

* doc(Thread): Thread::trySleep() assertion #3710

* fix(PollSet): wakeup fd is never read (windows portion and some other optimizations) #3708

* feat(SocketReactor): improvements #3713

* chore(ThreadTest): add missing include

* fix(PollSet): wakeup fd is never read #3708

* fix(Any): #3682 #3683 #3692 #3712

* fix(mingw): lowercase winsock2 and iphlpapi to allow cross compile #3711

* feat(Thread): Add Thread::set/getAffinity() #3709

* chore(SocketReactor): one-liners inlined, removed redundant try/catch in dospatch, remove unused onBusy()

* feat(SocketReactor): add socket to ErrorNotification

* fix(SocketReactor): pollTimeout assignment and ConnectorTest leak
@aleks-f aleks-f added the fixed label Jul 31, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

This issue is stale because it has been open for 365 days with no activity.

@github-actions github-actions bot added the stale label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

This issue was closed because it has been inactive for 60 days since being marked as stale.

@github-actions github-actions bot closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant