Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poco::Net::SocketConnector constructor should take SocketAddress by const reference #3968

Closed
obiltschnig opened this issue Mar 13, 2023 · 0 comments · Fixed by #4030
Closed

Poco::Net::SocketConnector constructor should take SocketAddress by const reference #3968

obiltschnig opened this issue Mar 13, 2023 · 0 comments · Fixed by #4030
Assignees
@obiltschnig
Labels
enhancement fixed
Milestone
Release 1.12.5

Comments

@obiltschnig
Copy link
Member

Currently it takes a non-const reference which is both unnecessary and a major inconvenience.
@obiltschnig obiltschnig added this to the Release 1.12.5 milestone Mar 13, 2023
@obiltschnig obiltschnig self-assigned this Mar 13, 2023
bas524 added a commit to bas524/poco that referenced this issue May 11, 2023
@bas524
fix pocoproject#3968 Poco::Net::SocketConnector constructor should ta…
69a6ddb 
…ke SocketAddress by const reference
@bas524 bas524 mentioned this issue May 11, 2023
Merged
obiltschnig added a commit that referenced this issue Jun 6, 2023
@obiltschnig
Merge pull request #4030 from bas524/socketaddress-by-const
525e91c 
fix #3968
aleks-f pushed a commit that referenced this issue Nov 27, 2023
@bas524 @aleks-f
fix #3968 Poco::Net::SocketConnector constructor should take SocketAd…
8bf2c5d 
…dress by const reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obiltschnig obiltschnig

Labels
enhancement fixed
Projects
None yet
Milestone
Release 1.12.5
Development

Successfully merging a pull request may close this issue.

fix #3968 bas524/poco
1 participant
@obiltschnig