Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move autoCommit to AbstractSessionImpl #4261

Closed
aleks-f opened this issue Nov 11, 2023 · 0 comments
Closed

Move autoCommit to AbstractSessionImpl #4261

aleks-f opened this issue Nov 11, 2023 · 0 comments
Assignees
@aleks-f
Labels
enhancement fixed
Milestone
Release 1.13.0

Comments

@aleks-f
Copy link
Member

aleks-f commented Nov 11, 2023

this is a common feature and it should be handled by front end
@aleks-f aleks-f added this to the Release 1.13.0 milestone Nov 11, 2023
@aleks-f aleks-f self-assigned this Nov 11, 2023
aleks-f added a commit that referenced this issue Nov 11, 2023
@aleks-f
feat(Data::AbstractSessionImpl): add autoCommit property and tests #4261
381ac1d
@aleks-f aleks-f added the fixed label Nov 12, 2023
aleks-f added a commit that referenced this issue Nov 13, 2023
@aleks-f
fix(Data::AbstracSessionImpl): protect autocommit feature handlers #4261
ffd0007
aleks-f added a commit that referenced this issue Dec 22, 2023
@aleks-f @frwilckens
feat(Data::AbstractSessionImpl): add autoCommit property and tests #4261
86084cb 
 (#4262)

* fix(Data::AbstracSessionImpl): protect autocommit feature handlers #4261

* chore(CI): re-enable mysql

* MySQL SessionImpl: make sure autocommit mode is on when session is openend or reset.

* PostgreSQL SessionImpl: reuse autocommit flag of AbstractSessionImpl.

* Github workflow: re-activated linux-gcc-make-postgres

* Fixed indentation in ci.yml

* Fix for DataTest SQLExecutor: use connector

* Data::Session: when parser is not used and autocommit mode is off, assume any SQL statement begins a transaction.

* PostgreSQL: don't use SQL parser (it currently cannot handle placeholders).

* PostgreSQL: added test sessionTransactionNoAutoCommit

* PostgreSQL test suite: removed reference to generic SQLExecutor

* PostgreSQL: fixes for sessionTransactionNoAutoCommit.

* MySQL: added test sessionPoolAndUnicode (from #2801)

* Fixed #define in sql-parser

* Data generic testsuite: support numbered placeholders

* PostgreSQL test suite: added missing include directory to Makefile.

* Attempt to fix PostgreSQL Makefiles

* PostgreSQL testsuite: added include path to Makefile

* PostgreSQL testsuite: added PocoDataTest library to Makefile

* DataTest SQLExecutor::formatSQL: don't use string_view

* PostgreSQL test suite: delegated most tests to Poco::Data::Test

* Makefile: added dependencies on Data-Tests

* Weaken assumptions about async in generic transaction tests

* Makefile: added dependency for Prometheus samples

* Fix deadlock in DataTest SQLExecutor

* PostgreSQL tests SQLExecutor: cleanup

* feat(Data::AbstractSessionImpl): add autoCommit property and tests #4261

* Brought MySQL backend in line with _autoCommit flag of AbstractSessionImpl.

---------

Co-authored-by: Friedrich Wilckens <frwilckens@gmail.com>
Co-authored-by: Friedrich Wilckens <friedrich.wilckens@ingramcontent.com>
@aleks-f aleks-f closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleks-f aleks-f

Labels
enhancement fixed
Projects
None yet
Milestone
Release 1.13.0
Development

No branches or pull requests
1 participant
@aleks-f