Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always set thread names on POSIX platforms #3384

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Always set thread names on POSIX platforms #3384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96902f2
chore: gitignore vim .swp files
carun Aug 15, 2021
d13fe77
feat(POSIX): Always set thread names.
carun Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,10 @@ cmake-build/
*.bak
stage/
releases/

# vim #
#######
*.orig
*.swp
*.vim
tags
8 changes: 0 additions & 8 deletions Foundation/src/Thread_POSIX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ namespace
#endif


#if defined(POCO_POSIX_DEBUGGER_THREAD_NAMES)


namespace {
void setThreadName(pthread_t thread, const std::string& threadName)
{
Expand All @@ -83,9 +80,6 @@ void setThreadName(pthread_t thread, const std::string& threadName)
}


#endif


namespace Poco {


Expand Down Expand Up @@ -357,9 +351,7 @@ void* ThreadImpl::runnableEntry(void* pThread)
#endif

ThreadImpl* pThreadImpl = reinterpret_cast<ThreadImpl*>(pThread);
#if defined(POCO_POSIX_DEBUGGER_THREAD_NAMES)
setThreadName(pThreadImpl->_pData->thread, reinterpret_cast<Thread*>(pThread)->getName());
#endif
AutoPtr<ThreadData> pData = pThreadImpl->_pData;
try
{
Expand Down