Custom rotate, archive and purge strategies for FileChannel #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewauclair
changed the title
|
@andrewauclair for some reason, this did not trigger CI builds. can you please push a dummy commit to trigger it so we can see it green before merge. I'll mark it for 1.13.0 |
aleks-f
pushed a commit
that referenced
this pull request
Nov 27, 2023
* Adding the ability to set custom rotate, archive and purge strategies. * Force CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at making an improved version of #3101 that has tests.
setRotationStrategy,setArchiveStrategyandsetPurgeStrategyallow setting custom strategies to be used by theFileChannel.These new functions take a non-null pointer and
FileChannelowns the pointer after the call and will delete it when necessary.Also changed
FileChannelto use a newNullRotationStrategyandNullPurgeStrategyinstead of null pointers.One thing to note about these changes right now is that setting a property will still internally create a new strategy in
FileChannel, overwriting the one provided to the set strategy functions. I think this is ok and I don't have any better ideas right now.Personally, I've wanted this ability with Poco at work for a while so that we can start each log file with the version of software. It's currently difficult to know what version a customer is using when they send us log files.