Remove unnecessary dup. of std::string in NumberParser::tryParseFloat #3864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumberParser::tryParseFloat is calling this overload:
bool strToDouble(const std::string& str, double& result, char decSep, char thSep, const char* inf, const char* nan)
Since it accepts a const std::string& str,, calling with s.c_str() will create a temporary std::string to call strToDouble
Maybe a possible patch for strToDouble would be change the strToDouble to receive a string by value without const ref and remove the std::string tmp from the code, thisway can avoid some possible multiple duplications when calling with a char* or similar.