Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding API XML::AbstractContainerNode::insertAfterNP() #4061

Merged
merged 1 commit into from Nov 26, 2023

Conversation

tuduongquyet
Copy link
Contributor

@tuduongquyet tuduongquyet commented Jun 22, 2023

Adding API XML::AbstractContainerNode::insertAfter()

Request: #3845

@aleks-f aleks-f added this to the Release 1.13.0 milestone Jul 11, 2023
@aleks-f aleks-f requested a review from obiltschnig July 11, 2023 12:07
@aleks-f aleks-f linked an issue Jul 11, 2023 that may be closed by this pull request
@obiltschnig
Copy link
Member

Since this method is not part of the DOM specification, it should be named insertAfterNP().

Copy link
Member

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuduongquyet please rename to insertAfterNP()

@tuduongquyet
Copy link
Contributor Author

Yes,
API renamed to insertAfterNP()

@tuduongquyet tuduongquyet reopened this Oct 23, 2023
@aleks-f aleks-f removed the request for review from obiltschnig November 26, 2023 18:02
@aleks-f aleks-f changed the title Adding API XML::AbstractContainerNode::insertAfter() Adding API XML::AbstractContainerNode::insertAfterNP() Nov 26, 2023
@aleks-f aleks-f merged commit af69d61 into pocoproject:devel Nov 26, 2023
aleks-f pushed a commit that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poco::XML::Node insertAfter API
3 participants