Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimeParser Validation and Performance Improvements #4593

Merged
merged 5 commits into from
Jun 29, 2024

Commits on Jun 25, 2024

  1. DateTimeParser Improvements

    Improve the validation of DateTimeParser by validating the numbers parsed for day, month, year, hour, minute, second, millis and micros.
    
    Improve performance by caching the RegularExpressions created in DateTimeFormat::isValid.
    andrewauclair committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2f399dd View commit details
    Browse the repository at this point in the history
  2. DateTimeParser Validation

    Additional change to validate milliseconds field if the . or , exists.
    andrewauclair committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5d3d19a View commit details
    Browse the repository at this point in the history
  3. Fix CodeQL Issues

    andrewauclair committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    85b3c34 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Fix Naming

    andrewauclair committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    00c6f94 View commit details
    Browse the repository at this point in the history
  2. Removing REGEX_LIST

    REGEX_LIST was only used in isValid, which now uses a cached list of RegularExpressions instead.
    andrewauclair committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    325f35e View commit details
    Browse the repository at this point in the history