Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle race condition for unanalyzed files #68

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mejackreed
Copy link
Contributor

No description provided.

@cbeer
Copy link
Contributor

cbeer commented Nov 4, 2020

What's the race condition? That we're not able to read files until they go through the analyzers?

@mejackreed
Copy link
Contributor Author

Mentioned in #67

However, this may unveil a race condition not previously noticed. Whereas, the after_commit in Upload may enqueue itself and be ran before analysis has completed.

But maybe its not a problem especially if we don't depend on any analysis metadata. I thought I ran into an issue with this, but now I can't recreate it.

@mejackreed mejackreed marked this pull request as draft November 4, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants