Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snyk as a blocking step to the build workflow #52

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

jonathansmolenski
Copy link
Contributor

Github Issue: #Snyk Blocking Step

Description

This code adds a blocking step to the github actions to stop the build if any fixable vulnerabilities are found

Overview of work done

One github action added to scan with Snyk

Overview of verification done

I've run the build workflow and the step added runs and passes without issue

Overview of integration done

The change affects only the testing portion of the github action workflow, no functional changes were made

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

Copy link
Collaborator

@jamesfwood jamesfwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frankinspace frankinspace merged commit 1352241 into develop Jan 18, 2023
@frankinspace frankinspace deleted the snyk_blocking_step branch January 18, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants