Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve authentication workflow #10

Merged
merged 9 commits into from
May 12, 2023
Merged

Improve authentication workflow #10

merged 9 commits into from
May 12, 2023

Conversation

marco-souza
Copy link
Contributor

@marco-souza marco-souza commented May 12, 2023 •
edited
Loading

Description

This PR add some enhancements to the login workflow

  • share configs and auth utils
  • add redirect logic for /app and /login
  • cleanup imports
  • update middleware to run in /app/* routes

Next Steps

  • persist user role when sign in
  • redirect login by user role

@vercel
Copy link

vercel bot commented May 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app ✅ Ready (Inspect) Visit Preview May 12, 2023 2:03pm

@marco-souza marco-souza self-assigned this May 12, 2023
nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I was working on the same issue but with a different approach. Yours looks better!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vitorschelb
vitorschelb approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vitorschelb
vitorschelb approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco-souza marco-souza merged commit 1ee18d3 into main May 12, 2023
@marco-souza marco-souza deleted the marco/handle-redirects branch May 12, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbrandao nicolasbrandao nicolasbrandao approved these changes

@vitorschelb vitorschelb vitorschelb approved these changes

Assignees

@marco-souza marco-souza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marco-souza @nicolasbrandao @vitorschelb