Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting issues #11

Merged
merged 5 commits into from
May 12, 2023
Merged

Fix linting issues #11

merged 5 commits into from
May 12, 2023

Conversation

marco-souza
Copy link
Contributor

Description

This PR improves our quality gatekeepers

  • installed prettier, husky, lint-staged
  • add PR template
  • format codebase

I suggest reviewing it commit by commit

Next Steps

  • add GitHub Actions for checking it on each PR

@marco-souza marco-souza self-assigned this May 12, 2023
@vercel
Copy link

vercel bot commented May 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2023 6:49pm

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolasbrandao
nicolasbrandao approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vitorschelb
vitorschelb approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

@marco-souza marco-souza merged commit 1026331 into main May 12, 2023
@marco-souza marco-souza deleted the marco/fix-linting-issues branch May 12, 2023 19:06
marco-souza
marco-souza commented May 12, 2023
View reviewed changes
Copy link
Contributor Author

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

package.json Show resolved Hide resolved
.lintstagedrc.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbrandao nicolasbrandao nicolasbrandao approved these changes

@vitorschelb vitorschelb vitorschelb approved these changes

Assignees

@marco-souza marco-souza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marco-souza @nicolasbrandao @vitorschelb