Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox for tasklist with local persistence #20

Merged
merged 4 commits into from
May 19, 2023

Conversation

vitorschelb
Copy link
Contributor

@vitorschelb vitorschelb commented May 18, 2023

Description

This PR [Created simple checkbox for tasklist and temporary localStorage persistence]

  • Checkbox created
  • TW Adjustments
  • Local Storage persistence with useEffect
  • Local Storage refactored on a separated function

Next Steps

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 1:56pm

Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good job!

As a follow-up, we should consider creating set/get functions outside the components to make it more readable

src/components/TaskList.tsx Outdated Show resolved Hide resolved
src/components/TaskList.tsx Outdated Show resolved Hide resolved
src/components/TaskList.tsx Outdated Show resolved Hide resolved
src/components/TaskList.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀

Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitorschelb vitorschelb merged commit 5b84e6d into main May 19, 2023
@vitorschelb vitorschelb deleted the vitorschelb/onboarding branch May 19, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants