Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding Form #25

Merged
merged 10 commits into from
May 29, 2023
Merged

Onboarding Form #25

merged 10 commits into from
May 29, 2023

Conversation

vitorschelb
Copy link
Contributor

@vitorschelb vitorschelb commented May 25, 2023 •
edited
Loading

Onboarding Form

This PR improves onboardin form

  • Classes on Globals fixed
  • The elements input, label, title, select, and formContainer have been componentized with specific styles.
  • New questions based on reception team

Next Steps

@vercel
Copy link

vercel bot commented May 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2023 6:41pm

vitorschelb
vitorschelb commented May 25, 2023
View reviewed changes
src/app/globals.css Outdated Show resolved Hide resolved
@vitorschelb vitorschelb self-assigned this May 26, 2023
marco-souza
marco-souza reviewed May 26, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Much better with these shared components 🥳 🎉

I'll take a look at the rest of it later

marco-souza
marco-souza reviewed May 27, 2023
View reviewed changes
src/components/OnboardingForm.tsx Outdated Show resolved Hide resolved
src/components/OnboardingForm.tsx Outdated Show resolved Hide resolved
src/shared/components.tsx Outdated Show resolved Hide resolved
src/components/OnboardingForm.tsx Outdated Show resolved Hide resolved
vitorschelb
vitorschelb commented May 27, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feedbacks from the reception team have been implemented.

@vitorschelb vitorschelb marked this pull request as ready for review May 27, 2023 18:30
vitorschelb
vitorschelb commented May 27, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some refs that passed in blank, I will be more careful to avoid those silly commits next time! Thank you guys.

@vitorschelb vitorschelb changed the title Form Draft Onboarding Form May 29, 2023
@vitorschelb vitorschelb merged commit c675e74 into main May 29, 2023
@vitorschelb vitorschelb deleted the vitorschelb/form-logic branch May 29, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-souza marco-souza marco-souza approved these changes

@nicolasbrandao nicolasbrandao Awaiting requested review from nicolasbrandao

@guilherme-bbsa guilherme-bbsa Awaiting requested review from guilherme-bbsa

@Raysson-ornelas Raysson-ornelas Awaiting requested review from Raysson-ornelas

@vzsoares vzsoares Awaiting requested review from vzsoares

Assignees

@vitorschelb vitorschelb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitorschelb @marco-souza