Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Onboarding Form Validation #26

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Implement Onboarding Form Validation #26

merged 5 commits into from
Jun 6, 2023

Conversation

vitorschelb
Copy link
Contributor

@vitorschelb vitorschelb commented May 31, 2023 •
edited
Loading

Description

This PR implements the validation of zod and the use of react-hook-forms.

  • Implement react hook form
  • Implement zod
  • Create zod schema and type
  • fix: forwardRef on form components

Next Steps

  • Create Button
  • Dissociate forms submit.
  • Try to fix: " eslint-disable-next-line react/display-name" on form components
  • ref form with useFormContext

@vitorschelb vitorschelb self-assigned this May 31, 2023
@vercel
Copy link

vercel bot commented May 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 10:30pm

vitorschelb
vitorschelb commented May 31, 2023
View reviewed changes
src/app/app/page.tsx Outdated Show resolved Hide resolved
vitorschelb
vitorschelb commented May 31, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following draft needs to be refactored, and the highlighted steps in the PR description need to be implemented.

nicolasbrandao
nicolasbrandao approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⭐

marco-souza
marco-souza reviewed Jun 6, 2023
View reviewed changes
src/shared/onboarding.ts Show resolved Hide resolved
src/shared/tw.tsx Outdated Show resolved Hide resolved
src/shared/components.tsx Outdated Show resolved Hide resolved
src/components/OnboardingForm.tsx Show resolved Hide resolved
@vitorschelb vitorschelb changed the title Improves Onboarding Form Implement Onboarding Form Validation Jun 6, 2023
vitorschelb
vitorschelb commented Jun 6, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formSchema name has been changed, and its type has been moved to onboarding.ts.
The requested changes will be addressed in a next PR.

@vitorschelb vitorschelb marked this pull request as ready for review June 6, 2023 21:26
vitorschelb
vitorschelb commented Jun 6, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema type moved to onboarding, merge conflict fixed.

vitorschelb
vitorschelb commented Jun 6, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint issue with forwardRef display-name fixed.
Indentation ref.

marco-souza
marco-souza approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vitorschelb vitorschelb merged commit f06d93c into main Jun 6, 2023
@vitorschelb vitorschelb deleted the vitorschelb/parsing-form branch June 6, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-souza marco-souza marco-souza approved these changes

@nicolasbrandao nicolasbrandao nicolasbrandao approved these changes

@Raysson-ornelas Raysson-ornelas Awaiting requested review from Raysson-ornelas

@vzsoares vzsoares Awaiting requested review from vzsoares

@guilherme-bbsa guilherme-bbsa Awaiting requested review from guilherme-bbsa

Assignees

@vitorschelb vitorschelb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitorschelb @marco-souza @vzsoares @nicolasbrandao