Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validates data from form steps according to zod schemas. #36

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Validates data from form steps according to zod schemas. #36

merged 3 commits into from
Jul 7, 2023

Conversation

vitorschelb
Copy link
Contributor

Description

This PR validates the data of the form steps according to zod schemas.

  • Creates FormProps type to export onSubmit and moveNextStep functions as props on intanced component.
  • Creates logic to parse the data inputs through zod schemas
  • Create temporary validation test on registration schema.

Next Steps

  • Create a hook

@vitorschelb vitorschelb self-assigned this Jun 30, 2023
@vercel
Copy link

vercel bot commented Jun 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 7:09pm

@vitorschelb vitorschelb changed the title Validate the data of the form steps according to zod schemas. Validates data from form steps according to zod schemas. Jun 30, 2023
marco-souza
marco-souza reviewed Jun 30, 2023
View reviewed changes
src/app/app/onboarding/page.tsx Outdated Show resolved Hide resolved
src/app/app/onboarding/page.tsx Outdated Show resolved Hide resolved
src/app/app/onboarding/page.tsx Show resolved Hide resolved
src/components/forms/OnboardingContact.tsx Outdated Show resolved Hide resolved
src/components/forms/OnboardingContact.tsx Show resolved Hide resolved
src/hooks/useOnboardingForm.tsx Outdated Show resolved Hide resolved
src/shared/onboarding.ts Outdated Show resolved Hide resolved
src/components/forms/OnboardingRegistration.tsx Outdated Show resolved Hide resolved
src/components/forms/OnboardingAbout.tsx Show resolved Hide resolved
src/hooks/useOnboardingForm.tsx Outdated Show resolved Hide resolved
vitorschelb
vitorschelb commented Jul 7, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we agreed in the daily, all the steps logic, submit and validation gonna be integrated with context on the next PR.

vitorschelb
vitorschelb commented Jul 7, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to create the context on this PR.

@vitorschelb vitorschelb merged commit 6cd9c99 into main Jul 7, 2023
1 check passed
@vitorschelb vitorschelb deleted the vitorschelb/form-validation branch July 7, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raysson-ornelas Raysson-ornelas Raysson-ornelas left review comments

@marco-souza marco-souza marco-souza approved these changes

@vzsoares vzsoares Awaiting requested review from vzsoares

@nicolasbrandao nicolasbrandao Awaiting requested review from nicolasbrandao

Assignees

@vitorschelb vitorschelb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitorschelb @marco-souza @Raysson-ornelas