Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

61: Enhance repository documentation regarding project setup and execution #67

Merged
merged 39 commits into from
Oct 24, 2023

Conversation

ogatalars
Copy link
Contributor

@ogatalars ogatalars commented Sep 13, 2023

Description

This PR aims to improve and expand the project's README documentation. The current README provides a basic overview, but it lacks comprehensive information that would be beneficial to both developers and users. This update is focused on making the README more informative, user-friendly, maintainable and engaging.

add: requirements and introduction
fix: some .md problems
fix: some minor text problems
feat: more adjusts on readme
fix: capital letters
refactor: minor adjustments
@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 1 resolved Oct 12, 2023 7:21pm

add: some minor problems
add some lines to make more readable
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect job!

The docs are looking great! 😊

README.md Show resolved Hide resolved
Copy link

@frattezi frattezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey folks! Docs look awesome! I loved it! ❤️

Just added some minor fixes! But we're almost there! Thank you for you work! 🚀 🙇🏼

README.md Outdated Show resolved Hide resolved
docs/setup-and-running.md Outdated Show resolved Hide resolved
docs/setup-and-running.md Outdated Show resolved Hide resolved
docs/setup-and-running.md Show resolved Hide resolved
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thank you!

I'd address the Supabase line only - I left a comment on it.

README.md Outdated Show resolved Hide resolved
docs/contribution-guidelines.md Show resolved Hide resolved
Copy link

@frattezi frattezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey folks, thank you for solving the issues I previously pointed out. I recommend installing the extension I've mentioned and do a quick lint over all the files in the PR, thank you!

Also, can you please add more meaningful names for the images? You can change the example-images folder names and patterns like this:

images/
  - contribution-guidelines/
    -  descriptve-image-name.png

Please note the changes I'm asking:

  • example-images now is called images.
  • We have a folder for each file the images belong to
  • Images have descriptive names, to be easily identified.

Thank you 🚀 We are almost there!

docs/setup-and-running.md Outdated Show resolved Hide resolved
docs/setup-and-running.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@Luana-ns Luana-ns removed the request for review from wfabi0 October 13, 2023 22:26
Copy link

@frattezi frattezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the work you have put on this task guys, NOW WE HAVE A README!!

Awesome work, thank you a lot for being so patient and quickly answering the conversations here in the PR, you did amazing!

Lets go with the merge! :shipit:
@Luana-ns @ogatalars

@ogatalars ogatalars merged commit 40f5162 into main Oct 24, 2023
3 checks passed
@ogatalars ogatalars deleted the ogata-lua/improve-readme branch October 24, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
5 participants