This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Added functionality to create a new Space Contact #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@holm is the code OK? I'm about to write a method for updating the Space Contact so I'd like to know if I am on the right way. |
|
Looks good |
holm
pushed a commit
that referenced
this pull request
Mar 3, 2015
Added functionality to create a new Space Contact
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added the functionality to create a new Space Contact. I didn't write any unit-test as I don't know if I am allowed to do that, so the code is not tested yet.
Note:
I didn't know exactly what class to take as the "create" attribute for the addSpaceContact() method. I have looked at the other classes, e.g. Profile.java, but I found the fields different from those written at https://developers.podio.com/doc/contacts so I decided to create a new class ContactCreate for creating new contacts. Or would it be better to update the fields in class Profile and use this one?