[Stripe] Implement Refund event listener in Stripe webhook #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
github-actions
bot
removed
the
run tests
github-actions
bot
removed
the
run tests
github-actions
bot
removed
the
run tests
igoychev
requested changes
Oct 29, 2023
Comment on lines
50
to
51
| Транзакцията ще отнеме от 5 до 10 дни и парите ви ще бъдат върнати по същия начин, по | ||
| който са били получени. <br /><br /> |
There was a problem hiding this comment.
нека да променим текста за да е малко по-ясно:
"парите ще ви бъдат върнати към същата карта, с която сте превели дарението към Страйп."
Comment on lines
+485
to
+491
| /** | ||
| * Refund a stipe payment donation | ||
| * https://stripe.com/docs/api/refunds/create | ||
| * @param inputDto Refund-stripe params | ||
| * @returns {Promise<Stripe.Response<Stripe.Refund>>} | ||
| */ | ||
| async refundStripePayment(paymentIntentId: string): Promise<Stripe.Response<Stripe.Refund>> { |
There was a problem hiding this comment.
great for including the reference to the docs!
|
|
||
| return await this.stripeClient.refunds.create({ | ||
| payment_intent: paymentIntentId, | ||
| reason: 'requested_by_customer', |
There was a problem hiding this comment.
[TODO] for next version, it would be good to allow several predefined reasons and a free text that can be selected/entered on the fronted from the Admin UI.
I will write a separate ticket for this
Comment on lines
+192
to
+195
| await this.sendEmail.sendFromTemplate(mail, recepient, { | ||
| //Allow users to receive the mail, regardles of unsubscribes | ||
| bypassUnsubscribeManagement: { enable: true }, | ||
| }) |
github-actions
bot
removed
the
run tests
igoychev
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we will handle stripe refund event, so that in case of Refund request, the refunded amounts to be properly substracted.
The refund itself is by calling /api/v1/donation/refund-stripe-paymet/ endpoint or from billing Stripe Admin UI. After refund request is received Stripe sends a charge.refunded event: https://stripe.com/docs/api/refunds/object
After we receive this event, we will:
Relates to podkrepi-bg/frontend#1635
Closes #518 and podkrepi-bg/frontend#1585
Test:
Created a donation:
After refund button is clicked - donation is not present in the campaign tab:
End user will receive the following mail: