Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated admin/users grid to server-side pagination #1551

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

tongo-angelov
Copy link
Contributor

Changed admin/users data grid to use server-side pagination and sorting

Closes #1474

Since I've updated usePersonList hook I had to update each place that uses it

@github-actions
Copy link

github-actions bot commented Aug 13, 2023

✅ Tests will run for this PR. Once they succeed it can be merged.

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Aug 14, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 14, 2023
Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, just please confirm if default params are needed on the list function

src/service/apiEndpoints.ts Show resolved Hide resolved
src/pages/admin/users/index.tsx Outdated Show resolved Hide resolved
@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Aug 14, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Aug 14, 2023
Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@igoychev igoychev merged commit 260931a into podkrepi-bg:master Aug 14, 2023
11 of 12 checks passed
@tongo-angelov tongo-angelov deleted the admin-users branch August 14, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server-side paging, filtering and search for Registered users on Admin Site
2 participants