New design notifications news #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
ani-kalpachka
approved these changes
Nov 28, 2023
* headings font size bug fixes * removed library from package.json
* Terms and GDPR added in the registerForm * Format check added * Some error messages added in the RegisterForm
* update README.md [skip ci] * update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: igoychev <igoychev@gmail.com>
Co-authored-by: ani-kalpachka <ani.kalpachka888@abv.bg>
Co-authored-by: ani-kalpachka <ani.kalpachka888@abv.bg>
…1624) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.8 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* upgraded NextJS to fix dependabot vulnerability warnings * fixed linter and formatting * reverted next to 13.4.12, updated MUI and translation libraries * upgraded playwright to latest * fixed language change and corrected decimal separators * forced resolution for postcss and zod to fix security recommendations * added locale for tests to fix decimal separator mixups * donation amount changed to integer to avoid language specific decimal separators * upgraded node to v20 * fixing the docker build context to use the already checked out code from github checkout action
* Update Guarantors slider * Revert unnecessary changes --------- Co-authored-by: ani-kalpachka <ani.kalpachka888@abv.bg>
* Update bank details on donation * Update reasoning --------- Co-authored-by: ani-kalpachka <ani.kalpachka888@abv.bg>
Bumps [crypto-js](https://github.com/brix/crypto-js) from 4.1.1 to 4.2.0. - [Commits](brix/crypto-js@4.1.1...4.2.0) --- updated-dependencies: - dependency-name: crypto-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update next version to 13.5.4 * i18n: Fix translations not working for dynamic paths * i18next.config: Detect user's locale from NEXT_LOCALE cookie
Co-authored-by: ani-kalpachka <ani.kalpachka888@abv.bg>
* Add refund button * Add refundStore * Fix prettier problem * Remove log * Fix typos * refundClickClickHandler -> refundClickHandler * Show extPaymentId in confirmation box * Fix button typo
* fix: shows tabs for donors and wishes * fix: wishes tab shows messages and pagination * fix: adds btn 'Show all' to wishes tab, align wishes array * fix: InfoIcon align * fix: shuffle wishes array * fix: clear unused classes
Bumps [next-auth](https://github.com/nextauthjs/next-auth) from 4.22.1 to 4.24.5. - [Release notes](https://github.com/nextauthjs/next-auth/releases) - [Commits](https://github.com/nextauthjs/next-auth/compare/next-auth@4.22.1...next-auth@4.24.5) --- updated-dependencies: - dependency-name: next-auth dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove legacy hotjar implementation Hotjar is now loaded through the GTM * CampaignsPage.tsx: Remove Hotjar implementation
) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ani Kalpachka <ani.kalpachka@merkle.com>
… in (podkrepi-bg#1677) When user logs in trough donation step 2, person's data remains undefined due to data not being updated. Manually refetch the data coming from useCurrentPerson() after login to refresh the user's data
…litsaIlieva/frontend into new-design-notifications-news
sashko9807
requested changes
Dec 16, 2023
| @@ -8,13 +8,15 @@ import { TranslatableField, translateError } from 'common/form/validation' | |||
|
|
|||
| export type CheckboxFieldProps = { | |||
| name: string | |||
| sx?: object | |||
There was a problem hiding this comment.
Type should be SxProps<Theme>
| <CampaignFinanceSummary campaign={campaign} expenses={totalExpenses ?? 0} /> | ||
| </Grid> | ||
| {(expensesList?.length || canEditCampaign) && ( | ||
| {expensesList?.length || |
There was a problem hiding this comment.
Please consider merging with the latest master, because this condition as is, will hide the expenses table for normal users.
| @@ -28,6 +29,7 @@ export default function IndexPage() { | |||
| <PartnersSection /> | |||
| <TeamMembersSection /> | |||
| <JoinPodkrepiBgSection /> | |||
| <SubscriptionSection /> | |||
There was a problem hiding this comment.
Too many sections/buttons have been created to subscribe for the newsletter.
@swolf86 can you please point us to the final design of where the newsletter subscription's position should be on the main page.
There was a problem hiding this comment.
- under what have we achieved?
Съществуващата секция “Какво постигнахме досега” да се допълни с функционалност за абониране - under Who is behind Podkrepi.bg?
There was a problem hiding this comment.
There are 4 positions of the Subscribe for news according to the design in Figma. If something changed, please, update it on time
| @@ -73,7 +73,14 @@ | |||
| "save": "Запази", | |||
| "submit": "Изпрати", | |||
| "apply": "Кандидатствайте", | |||
| "subscribe": "Абониране за известия", | |||
| "subscribe": "Абонирай се за email известия за кампанията", | |||
There was a problem hiding this comment.
In my opinion translations for subscriptions, belong more to the notifications.json, but this is more of a personal opinion, rather than change request, thus feel free to leave it as is.
|
@sashko9807 The comments seem to be fixed. Could you please check and confirm? |
sashko9807
approved these changes
Jan 3, 2024
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1550 (news subscription)
Motivation and context
There is new design that should be implemented.
Screenshots:
Testing
Steps to test
Affected urls
Environment
New environment variables:
NEW_ENV_VAR: env var detailsNew or updated dependencies:
dependency/namev1.0.0v2.0.0