Fix FE issues - texts, translations, styles #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ani-kalpachka
changed the title
added 7 commits
May 14, 2024 14:41
ani-kalpachka
changed the title
sashko9807
requested changes
May 17, 2024
| @@ -162,7 +162,7 @@ export default function CampaignNewsSection({ campaign, canCreateArticle }: Prop | |||
| const { t, i18n } = useTranslation('news') | |||
| const { small }: { small: boolean } = useMobile() | |||
|
|
|||
| const INITIAL_HEIGHT_LIMIT = 200 | |||
| const INITIAL_HEIGHT_LIMIT = 203 | |||
src/pages/terms-of-service.tsx
Outdated
| @@ -4,7 +4,7 @@ import { serverSideTranslations } from 'next-i18next/serverSideTranslations' | |||
|
|
|||
| export const getStaticProps: GetStaticProps = async ({ locale }) => ({ | |||
| props: { | |||
| ...(await serverSideTranslations(locale ?? 'bg', ['common'])), | |||
| ...(await serverSideTranslations(locale ?? 'bg', ['common', 'validation', 'auth'])), | |||
There was a problem hiding this comment.
validation namespace doesn't seem to be needed.
If this change is regarding the missing translations of subscription modal, consider adding translations to those fields in the common namespace. Otherwise we would need to visit page by page, to see whether that particular page imports the auth namespace, as the subscription modal is available to all pages thru the footer.
sashko9807
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.