fix(security): sql injection in "Social & Donations" module

podlove · Aug 22, 2021 · aa8a343 · aa8a343
1 parent f53ddbe
commit aa8a343
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/lib/modules/social/model/contributor_service.php b/lib/modules/social/model/contributor_service.php
@@ -51,6 +51,9 @@ public function get_service_url()
 
     public static function find_by_contributor_id_and_category($contributor_id, $category = 'social')
     {
+        $contributor_id = (int) $contributor_id;
+        $category = $category == 'social' ? 'social' : 'donation';
+
         return self::all('WHERE service_id IN (SELECT id FROM '.Service::table_name()." WHERE `category` = '".$category."' ) AND `contributor_id` = ".$contributor_id);
     }
 }

diff --git a/lib/modules/social/model/show_service.php b/lib/modules/social/model/show_service.php
@@ -32,6 +32,8 @@ public function get_service_url()
 
     public static function find_by_category($category = 'social')
     {
+        $category = $category == 'social' ? 'social' : 'donation';
+
         return self::all('WHERE service_id IN (SELECT id FROM '.Service::table_name()." WHERE `category` = '".$category."' ) ORDER BY position ASC");
     }
 }

diff --git a/readme.txt b/readme.txt
@@ -106,6 +106,10 @@ This product includes GeoLite2 data created by MaxMind, available from http://ww
 
 == Changelog ==
 
+= 2021-08-22 =
+
+* fix(security): sql injection in "Social & Donations" module
+
 = 2021-05-02 =
 
 * fix: transcript API returns list again