Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "deprecated" message #1430

Merged
merged 1 commit into from Jan 24, 2024

Conversation

mjaschen
Copy link
Contributor

An optional method argument should not be followed by required argument. There's no need to specify a default value for $result as the empty array [] is provided as initial value for array_reduce() already.

PHP Deprecated:  Optional parameter $result declared before required parameter $contributor is implicitly treated as a required parameter in podlove-podcasting-plugin-for-wordpress/lib/modules/contributors/rest_api.php on line 76

(also removed two trailing whitespaces)

An optional method argument should not be followed by required argument.
There's no need to specify a default value for `$result` as the empty
array `[]` is provided as initial value for `array_reduce()` already.

```
PHP Deprecated:  Optional parameter $result declared before required parameter $contributor is implicitly treated as a required parameter in podlove-podcasting-plugin-for-wordpress/lib/modules/contributors/rest_api.php on line 76
```
@eteubert eteubert merged commit b1c8bd2 into podlove:master Jan 24, 2024
@eteubert
Copy link
Member

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants