Reemiting PoolCreated event (#302)

pods-finance · Aug 26, 2021 · 219ce08 · 219ce08
1 parent 6145d25
commit 219ce08
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 0 deletions.
diff --git a/abi/OptionAMMFactory.json b/abi/OptionAMMFactory.json
@@ -15,6 +15,31 @@
     "stateMutability": "nonpayable",
     "type": "constructor"
   },
+  {
+    "anonymous": false,
+    "inputs": [
+      {
+        "indexed": true,
+        "internalType": "address",
+        "name": "deployer",
+        "type": "address"
+      },
+      {
+        "indexed": false,
+        "internalType": "address",
+        "name": "pool",
+        "type": "address"
+      },
+      {
+        "indexed": false,
+        "internalType": "address",
+        "name": "option",
+        "type": "address"
+      }
+    ],
+    "name": "PoolCreated",
+    "type": "event"
+  },
   {
     "inputs": [],
     "name": "configurationManager",

diff --git a/contracts/amm/OptionAMMFactory.sol b/contracts/amm/OptionAMMFactory.sol
@@ -25,6 +25,8 @@ contract OptionAMMFactory is IOptionAMMFactory {
      */
     IFeePoolBuilder public immutable feePoolBuilder;
 
+    event PoolCreated(address indexed deployer, address pool, address option);
+
     constructor(IConfigurationManager _configurationManager, address _feePoolBuilder) public {
         require(
             Address.isContract(address(_configurationManager)),
@@ -62,6 +64,7 @@ contract OptionAMMFactory is IOptionAMMFactory {
         );
 
         address poolAddress = address(pool);
+        emit PoolCreated(msg.sender, poolAddress, _optionAddress);
         registry.setPool(_optionAddress, poolAddress);
 
         return poolAddress;

diff --git a/test/amm/OptionAMMFactory.test.js b/test/amm/OptionAMMFactory.test.js
@@ -54,6 +54,10 @@ describe('OptionAMMFactory', () => {
     const pool = await getPoolCreated(tx, option, configurationManager)
     const registry = await ethers.getContractAt('OptionPoolRegistry', await configurationManager.getOptionPoolRegistry())
 
+    await expect(tx)
+      .to.emit(factory, 'PoolCreated')
+      .withArgs(caller.address, pool.address, option.address)
+
     await expect(tx)
       .to.emit(registry, 'PoolSet')
       .withArgs(factory.address, option.address, pool.address)