Merge pull request #2363 from jamesgol/simplemulti

Allow save_post_meta to delete single meta elements instead of update
pods-framework · Sep 27, 2014 · 9227bc6 · 9227bc6
2 parents 65d0f35 + ee1f657
commit 9227bc6
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/classes/PodsAPI.php b/classes/PodsAPI.php
@@ -260,7 +260,7 @@ public function save_post_meta ( $id, $post_meta = null, $strict = false, $field
             else {
 				$simple = false;
 
-				if ( isset( $fields[ $meta_key ] ) && is_array( $meta_value ) ) {
+				if ( isset( $fields[ $meta_key ] ) ) {
 					$field_data = $fields[ $meta_key ];
 
 					$simple = ( 'pick' == $field_data[ 'type' ] && in_array( pods_var( 'pick_object', $field_data ), $simple_tableless_objects ) );
@@ -271,6 +271,10 @@ public function save_post_meta ( $id, $post_meta = null, $strict = false, $field
 
 					update_post_meta( $id, '_pods_' . $meta_key, $meta_value );
 
+					if ( ! is_array( $meta_value ) ) {
+						$meta_value = array( $meta_value );
+					}
+
 					foreach ( $meta_value as $value ) {
 						add_post_meta( $id, $meta_key, $value );
 					}
@@ -396,7 +400,7 @@ public function save_user_meta ( $id, $user_meta = null, $strict = false, $field
             else {
 				$simple = false;
 
-				if ( isset( $fields[ $meta_key ] ) && is_array( $meta_value ) ) {
+				if ( isset( $fields[ $meta_key ] ) ) {
 					$field_data = $fields[ $meta_key ];
 
 					$simple = ( 'pick' == $field_data[ 'type' ] && in_array( pods_var( 'pick_object', $field_data ), $simple_tableless_objects ) );
@@ -405,6 +409,10 @@ public function save_user_meta ( $id, $user_meta = null, $strict = false, $field
 				if ( $simple ) {
 					delete_user_meta( $id, $meta_key );
 
+					if ( ! is_array( $meta_value ) ) {
+						$meta_value = array( $meta_value );
+					}
+
 					foreach ( $meta_value as $value ) {
 						add_user_meta( $id, $meta_key, $value );
 					}
@@ -522,7 +530,7 @@ public function save_comment_meta ( $id, $comment_meta = null, $strict = false,
             else {
 				$simple = false;
 
-				if ( isset( $fields[ $meta_key ] ) && is_array( $meta_value ) ) {
+				if ( isset( $fields[ $meta_key ] ) ) {
 					$field_data = $fields[ $meta_key ];
 
 					$simple = ( 'pick' == $field_data[ 'type' ] && in_array( pods_var( 'pick_object', $field_data ), $simple_tableless_objects ) );
@@ -531,6 +539,10 @@ public function save_comment_meta ( $id, $comment_meta = null, $strict = false,
 				if ( $simple ) {
 					delete_comment_meta( $id, $meta_key );
 
+					if ( ! is_array( $meta_value ) ) {
+						$meta_value = array( $meta_value );
+					}
+
 					foreach ( $meta_value as $value ) {
 						add_comment_meta( $id, $meta_key, $value );
 					}