Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodsUI not taking params when generating the sort-links #4625

Open
hcarsten opened this issue Dec 7, 2017 · 0 comments
Open

PodsUI not taking params when generating the sort-links #4625

hcarsten opened this issue Dec 7, 2017 · 0 comments

Comments

@hcarsten
Copy link

hcarsten commented Dec 7, 2017

<a href="<?php echo esc_url_raw( pods_query_arg( array( 'orderby' . $this->num => $field, 'orderby_dir' . $this->num => $dir ), array( 'limit' . $this->num, 'search' . $this->num, 'pg' . $this->num, 'page' ), $this->exclusion() ) ); ?>"> <span><?php echo esc_html( $attributes[ 'label' ] ); ?></span> <span class="sorting-indicator"></span> </a>

I found a bug in PodsUI.php, here links to the sort/order are created. the function pods_query_arg is getting the arg “$allows” which does not take the $_GET params in consideration defined by an “advanced filter”.

The fast solution would be to set the parameter $allow to array()

@pglewis pglewis added this to the Pods 2.7.1 milestone Dec 7, 2017
@pglewis pglewis modified the milestones: Pods 2.7.1, Pods 2.7.2 Dec 8, 2017
@pglewis pglewis modified the milestones: Pods 2.7.2, Pods 2.7.3, Pods 2.7.4 May 2, 2018
@pglewis pglewis modified the milestones: Pods 2.7.4, Pods 2.7.5, Pods 2.7.6 Jun 6, 2018
@jimtrue jimtrue modified the milestones: Pods 2.7.6, Pods 2.7.7 Jun 8, 2018
@pglewis pglewis modified the milestones: Pods 2.7.7, Pods 2.7.8, Pods 2.7.9 Jul 26, 2018
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.9, Pods 2.7.10 Aug 9, 2018
@jimtrue jimtrue modified the milestones: Pods 2.7.10, Pods 2.7.11 Dec 5, 2018
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.11, Pods 2.7.12 Dec 6, 2018
@pglewis pglewis removed this from the Pods 2.7.12 milestone Dec 19, 2018
@pglewis pglewis added this to the Pods Future Release milestone Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants