Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow Modal #6996

Closed
pd-cm opened this issue Jan 23, 2023 · 6 comments
Closed

Narrow Modal #6996

pd-cm opened this issue Jan 23, 2023 · 6 comments
Assignees
@sc0ttkclark
Labels
Component: CSS Issues related to style adjustments Component: DFV Issues related to the Pods DFV JS that powers form fields Status: Need User Feedback Waiting on feedback from user who reported issue Status: Reproduced
Milestone
Pods 2.9.12

Comments

@pd-cm
Copy link
Contributor

pd-cm commented Jan 23, 2023 •
edited

Description

See https://wordpress.org/support/topic/dialog-for-new-pod-in-relationship-is-very-narrow/ for issue and suggested CSS.

@sc0ttkclark

Version

2.9.11

Testing Instructions

  1. Have a big monitor.
  2. Open a relationship modal.
  3. Profit?

Screenshots / Screencast

No response

Possible Workaround

See CSS in the linked .org posting.

Site Health Information

No response

Pods Package

No response
@sc0ttkclark sc0ttkclark added this to the Pods 2.9.12 milestone Jan 23, 2023
@sc0ttkclark sc0ttkclark self-assigned this Jan 23, 2023
@sc0ttkclark sc0ttkclark added Component: DFV Issues related to the Pods DFV JS that powers form fields Component: CSS Issues related to style adjustments labels Jan 23, 2023
@JoryHogeveen
Copy link
Member

@pd-cm

As mentioned on wp.org:

Could you verify that this also happens with all other plugins disabled on a default theme?
I cannot reproduce this behavior locally.

Cheers, Jory

@JoryHogeveen JoryHogeveen added Status: Need User Feedback Waiting on feedback from user who reported issue Status: Need Reproduction Issue must be reproduced before coding can begin and removed Type: Bug labels Jan 26, 2023
sc0ttkclark added a commit that referenced this issue Feb 20, 2023
@sc0ttkclark
Fix narrow modal issues
0ba8c42 
Fixes #6996
@sc0ttkclark
Copy link
Member

Fixed via 0ba8c42

@sc0ttkclark
Copy link
Member

I was able to reproduce this with the Pages add new button for the kitchen sink CPT pod. I don't remember seeing that issue before but perhaps it's an issue on Classic Editor only.

@JoryHogeveen
Copy link
Member

@sc0ttkclark I'm able to reproduce this behavior with the Gutenberg plugin enabled. It seems that this plugin is adding more general CSS than WP core does.

@JoryHogeveen JoryHogeveen added Status: Reproduced and removed Status: Need Reproduction Issue must be reproduced before coding can begin labels Mar 9, 2023
@sc0ttkclark
Copy link
Member

@JoryHogeveen Is that happening for you on main branch (unreleased 2.9.12)?

@JoryHogeveen
Copy link
Member

@sc0ttkclark I've checked the patch and this would fix the issue. It was more a comment for additional context :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc0ttkclark sc0ttkclark

Labels
Component: CSS Issues related to style adjustments Component: DFV Issues related to the Pods DFV JS that powers form fields Status: Need User Feedback Waiting on feedback from user who reported issue Status: Reproduced
Projects
Pods Core - Maintenance
Status: ✅ Done
Milestone
Pods 2.9.12
Development

No branches or pull requests
3 participants
@sc0ttkclark @JoryHogeveen @pd-cm