Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for issue number 3319 (Required files client side validation) #3327

Closed
wants to merge 7 commits into from

Conversation

JSeifBY
Copy link

@JSeifBY JSeifBY commented Dec 31, 2015

when adding a new post with a required field type 'File'; if i let the file empty the form is submitted and generate an error 'empty file' but the problem that the post has been added to the list without a file.

bug fix : iterate over pods required 'file' field type test if at least one file is selected, if not prevent submit and alert message showing 'You have same empty required files!'

Changelog:

  • Show required message for file fields that are required.

…e file empty the form is submitted and generate an error 'empty file' but the problem that the post has been added to the list without a file.

bug fix : iterate over pods required 'file' field type test if at least one file is selected, if not prevent submit and alert message showing 'You have same empty required files!'
@pglewis pglewis added this to the Pods 2.6.2 milestone Dec 31, 2015
@sc0ttkclark
Copy link
Member

I like what you're doing here, but we need a couple more tweaks to the text shown and I'd like to make the messaging / alert a little less alert(), maybe showing a message at the top of the screen <div id="message" class="error">....</div> or something like that, as well as messages and/or red markings on individual fields.

@sc0ttkclark sc0ttkclark modified the milestones: Pods Future Release, Pods 2.6.2 Jan 8, 2016
@JSeifBY
Copy link
Author

JSeifBY commented May 19, 2016

Sorry for that response delay,
i have just removed the alert dialog and added an inline error messages. I was thinking about adding notification manager like https://notifyjs.com/ to notify user of occurred errors (not only for required files), for example in long scroll pages we can't find the errors in a short time.

@sc0ttkclark
Copy link
Member

@JSeifBY can you provide collaborator access to your repository?

@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.x - Holding, Pods Future Release Jun 3, 2016
@JSeifBY
Copy link
Author

JSeifBY commented Jun 15, 2016

Done!

@sc0ttkclark sc0ttkclark added Keyword: Puntable Status: Help Wanted We have not prioritized this yet, but you can help make it happen to speed it up labels May 16, 2017
@sc0ttkclark sc0ttkclark changed the base branch from 2.x to release/2.7 June 1, 2017 23:30
ui/js/jquery.pods.js Outdated Show resolved Hide resolved
@sc0ttkclark
Copy link
Member

After some changes, it looks better. We need to update some of the JS here though to make sure the markup is right for 2.7

@pglewis can you check the logic of this out and confirm if markup it's using to add/remove the message is correct? Feel free to suggest changes that would be better overall for per-field validation messages.

@sc0ttkclark sc0ttkclark removed the Status: Help Wanted We have not prioritized this yet, but you can help make it happen to speed it up label Jun 1, 2017
@sc0ttkclark
Copy link
Member

@JSeifBY can you add access for @JoryHogeveen to your repo?

@sc0ttkclark sc0ttkclark changed the base branch from release/2.7 to release/2.8 December 6, 2017 06:53
ui/js/jquery.pods.js Outdated Show resolved Hide resolved
@sc0ttkclark sc0ttkclark dismissed a stale review via a5b04e7 February 10, 2020 04:08
sc0ttkclark
sc0ttkclark previously approved these changes Feb 10, 2020
@sc0ttkclark sc0ttkclark removed their assignment Feb 10, 2020
@sc0ttkclark sc0ttkclark modified the milestones: Backlog, Pods 2.8 Feb 10, 2020
@sc0ttkclark sc0ttkclark added Component: Frontend Forms Issues related to Pods public forms Focus: Accessibility Status: PR > QA pending QA needs to be done Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) labels Feb 10, 2020
JoryHogeveen
JoryHogeveen previously approved these changes Feb 10, 2020
Copy link
Member

@JoryHogeveen JoryHogeveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, other than that it's a go from me!

@sc0ttkclark sc0ttkclark changed the base branch from release/2.8 to feature/rest-api-admin February 17, 2020 18:56
@sc0ttkclark sc0ttkclark added Status: In Progress Issue or PR is currently in progress but not yet done and removed Status: PR > QA pending QA needs to be done Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) labels Feb 22, 2020
@sc0ttkclark sc0ttkclark dismissed stale reviews from JoryHogeveen and themself March 9, 2020 05:32

The base branch was changed.

@sc0ttkclark sc0ttkclark changed the base branch from feature/rest-api-admin to release/2.8 March 9, 2020 05:32
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.8, Pods 2.9 Aug 17, 2021
@sc0ttkclark sc0ttkclark deleted the branch pods-framework:release/2.8 October 18, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Frontend Forms Issues related to Pods public forms Focus: Accessibility Status: In Progress Issue or PR is currently in progress but not yet done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants