New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug for issue number 3319 (Required files client side validation) #3327
Conversation
…e file empty the form is submitted and generate an error 'empty file' but the problem that the post has been added to the list without a file. bug fix : iterate over pods required 'file' field type test if at least one file is selected, if not prevent submit and alert message showing 'You have same empty required files!'
I like what you're doing here, but we need a couple more tweaks to the text shown and I'd like to make the messaging / alert a little less |
…ror close to the input.
Sorry for that response delay, |
@JSeifBY can you provide collaborator access to your repository? |
Done! |
After some changes, it looks better. We need to update some of the JS here though to make sure the markup is right for 2.7 @pglewis can you check the logic of this out and confirm if markup it's using to add/remove the message is correct? Feel free to suggest changes that would be better overall for per-field validation messages. |
@JSeifBY can you add access for @JoryHogeveen to your repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, other than that it's a go from me!
Merge latest 2.8 code
The base branch was changed.
when adding a new post with a required field type 'File'; if i let the file empty the form is submitted and generate an error 'empty file' but the problem that the post has been added to the list without a file.
bug fix : iterate over pods required 'file' field type test if at least one file is selected, if not prevent submit and alert message showing 'You have same empty required files!'
Changelog: