Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy capabilities + No more hardcoded tax settings #3678

Merged
merged 2 commits into from Jul 16, 2016

Conversation

JoryHogeveen
Copy link
Member

Fix for:
#3676
#3677

@JoryHogeveen JoryHogeveen added Type: Feature Features that add entirely new functionality that was not there before Patch Status: Could not reproduce Issue cannot be reproduced labels Jul 16, 2016
@JoryHogeveen JoryHogeveen added this to the Pods 2.6.7 milestone Jul 16, 2016
@JoryHogeveen JoryHogeveen self-assigned this Jul 16, 2016
@jimtrue jimtrue added the Status: In Progress Issue or PR is currently in progress but not yet done label Jul 16, 2016
@JoryHogeveen JoryHogeveen added Fixed / Needs Testing and removed Status: In Progress Issue or PR is currently in progress but not yet done labels Jul 16, 2016
if ( 'custom' == $capability_type ) {
$capability_type = pods_var( 'capability_type_custom', $taxonomy, 'default' );
if ( ! empty( $capability_type ) && 'default' != $capability_type ) {
$capability_type .= '_terms';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add _terms for consistency with other plugins

@sc0ttkclark sc0ttkclark merged commit af3c882 into 2.x Jul 16, 2016
@sc0ttkclark sc0ttkclark deleted the feature/#3676_#3677 branch July 16, 2016 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Features that add entirely new functionality that was not there before
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants