Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always enqueue the DFV script by default if in the admin #5114

Merged
merged 2 commits into from Aug 17, 2018
Merged

Always enqueue the DFV script by default if in the admin #5114

merged 2 commits into from Aug 17, 2018

Conversation

pglewis
Copy link
Contributor

@pglewis pglewis commented Aug 17, 2018

Fixes #5111

@pglewis pglewis added this to the Pods 2.7.10 milestone Aug 17, 2018
@pglewis pglewis self-assigned this Aug 17, 2018
@pglewis pglewis mentioned this pull request Aug 17, 2018
Closed
@pglewis pglewis added Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) Type: Bug Component: DFV Issues related to the Pods DFV JS that powers form fields Status: PR > Pending Code Review PR is pending code review by core developers and removed Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) labels Aug 17, 2018
sc0ttkclark
sc0ttkclark reviewed Aug 17, 2018
View reviewed changes
classes/PodsAdmin.php Outdated
*
* @since 2.7.10
*/
if ( apply_filters( 'pods_default_enqueue_dfv', is_admin() ) ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set this as true since the action only runs in the admin area already.

@pglewis pglewis merged commit 15e1872 into 2.x Aug 17, 2018
@pglewis pglewis deleted the feature/5111-default-enqueue-dfv branch August 17, 2018 20:35
@pglewis pglewis mentioned this pull request Aug 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0ttkclark sc0ttkclark sc0ttkclark approved these changes

Assignees

@pglewis pglewis

Labels
Component: DFV Issues related to the Pods DFV JS that powers form fields Status: PR > Pending Code Review PR is pending code review by core developers Type: Bug
Projects
None yet
Milestone
Pods 2.7.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pglewis @sc0ttkclark