Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick/Select: Add new button disabled when the placeholder is selected in a dropdown #5404

Merged
merged 2 commits into from Jul 8, 2019
Merged

Pick/Select: Add new button disabled when the placeholder is selected in a dropdown #5404

merged 2 commits into from Jul 8, 2019

Conversation

pglewis
Copy link
Contributor

@pglewis pglewis commented Jul 1, 2019 •
edited by sc0ttkclark

Fixes #5401

Changelog:
Fixed: Stop add new button from being disabled when no selection has been made yet for single select #5401

@pglewis pglewis requested a review from sc0ttkclark as a code owner July 1, 2019 18:59
@pglewis pglewis mentioned this pull request Jul 1, 2019
Closed
@sc0ttkclark sc0ttkclark added this to the Pods 2.7.14 milestone Jul 5, 2019
@sc0ttkclark sc0ttkclark added the Status: PR > QA pending QA needs to be done label Jul 5, 2019
JoryHogeveen
JoryHogeveen approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@JoryHogeveen JoryHogeveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@sc0ttkclark sc0ttkclark merged commit c7093f3 into 2.x Jul 8, 2019
@sc0ttkclark sc0ttkclark deleted the feature/5401-addnew-disabled-single-select branch July 8, 2019 17:30
JoryHogeveen added a commit that referenced this pull request Jul 9, 2019
@JoryHogeveen
Changelog for #5409, #5404 & #5412 + Release date
0c2eac0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0ttkclark sc0ttkclark sc0ttkclark approved these changes

@JoryHogeveen JoryHogeveen JoryHogeveen approved these changes

Assignees

@JoryHogeveen JoryHogeveen

Labels
Status: PR > QA pending QA needs to be done Type: Bug
Projects
None yet
Milestone
Pods 2.7.14
Development

Successfully merging this pull request may close these issues.

BUG: Add New is Deactivated now for Single Select Relationships in 2.7.13
3 participants
@pglewis @sc0ttkclark @JoryHogeveen