Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods 2.8 i18n integration classes #6155

Merged
merged 47 commits into from Oct 14, 2021
Merged

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Sep 30, 2021

Description

This PR moved all i18n compatibility for third party plugins (WPML and Polylang) to dedicated integration classes.

Related GitHub issue(s)

Related: #5029

Tasklist

Testing instructions

  1. Install a translator (Polylang / WPML)
  2. Create at least two languages
  3. Add relationship fields for posts and taxonomies (type doesn't matter)
  4. Add posts and taxonomies for both languages (at least 3 and make sure the language locale is in the title so you can easily verify it works
  5. Check the options in the relationship fields. Only relationships of the SAME language should be available.
  6. Also check the shortcodes (query). If you query Pods from a page then the query should only return objects of the same language. Shortcode example: [pods name="test"]{@title} [/pods]
  7. Check if more complex shortcodes (with where statements etc.) keep working correctly.

Changelog text for these changes

PR checklist

@JoryHogeveen JoryHogeveen added Status: Need Dev Feedback Waiting on feedback from developer of PR Focus: i18n Status: In Progress Issue or PR is currently in progress but not yet done Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pending QA needs to be done labels Sep 30, 2021
@JoryHogeveen JoryHogeveen added this to the Pods 2.8 milestone Sep 30, 2021
@JoryHogeveen JoryHogeveen self-assigned this Sep 30, 2021
classes/Pods.php Outdated Show resolved Hide resolved
classes/PodsData.php Outdated Show resolved Hide resolved
sc0ttkclark
sc0ttkclark previously approved these changes Oct 5, 2021
@sc0ttkclark sc0ttkclark added Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) and removed Status: PR > Pending Code Review PR is pending code review by core developers Status: Need Dev Feedback Waiting on feedback from developer of PR labels Oct 5, 2021
@sc0ttkclark
Copy link
Member

@JoryHogeveen is #5945 confirmed resolved by this now?

We can go ahead and merge this ahead of the WPML call too, it's a major improvement

@JoryHogeveen
Copy link
Member Author

@sc0ttkclark
I'm not sure if #5945 is 100% resolved in this PR but I doub't remaining issues are actually related to this PR.
I do believe that this PR makes sure there are not query errors relating to WPML integration anymore so that part is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: i18n Status: PR > QA pending QA needs to be done Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and fix WPML integration + enhance i18n compatibility in general
2 participants