Datetime field fix for 00:00 times #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc0ttkclark
approved these changes
Jan 4, 2022
sc0ttkclark
added
Component: DFV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue with HTML5 datetime fields being reset to empty.
Related GitHub issue(s)
Fixes #6256.
Testing instructions
Follow instructions from #6256, try setting a time to midnight.
Changelog text for these changes
Fix: Fixes format for HTML5 datetime (and time) fields causing midnight values to become invalid. #6256
Enhancement: Removes some conditional code for Datetime field that aren't possible.
PR checklist