Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete delete action #6905

Merged
merged 6 commits into from Sep 17, 2022

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Sep 14, 2022

Description

See #6878
This PR implements a minimal drag distance of 1 pixel before activating dragging. This re-enables a simple click event on the remove button.

Related GitHub issue(s)

Fixes #6878

Screenshots / screencast

Changelog text for these changes

PR checklist

@JoryHogeveen JoryHogeveen added Type: Bug Status: PR > Pending Code Review PR is pending code review by core developers Component: DFV Issues related to the Pods DFV JS that powers form fields Status: PR > QA pending QA needs to be done Component: React Issues related to React JS labels Sep 14, 2022
@JoryHogeveen JoryHogeveen added this to the Pods 2.9.4 milestone Sep 14, 2022
@JoryHogeveen JoryHogeveen self-assigned this Sep 14, 2022
@JoryHogeveen JoryHogeveen changed the base branch from main to release/2.9.4 September 14, 2022 17:03
@JoryHogeveen
Copy link
Member Author

@sc0ttkclark @zrothauser
I couldn't find a way preventing the dragging event through the remove button itself. (Eg. disabling dragging on hover or something)
This was the best solution I could come up with.

React Select does support it's own sortable interface btw: https://react-select.com/advanced#sortable-multiselect

@sc0ttkclark
Copy link
Member

This fixes the issue for now and if we find a better approach then we can replace it

@sc0ttkclark sc0ttkclark merged commit c4db6da into release/2.9.4 Sep 17, 2022
@sc0ttkclark sc0ttkclark deleted the feature/6878-autocomplete-delete branch September 17, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: DFV Issues related to the Pods DFV JS that powers form fields Component: React Issues related to React JS Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pending QA needs to be done Type: Bug
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

deleting entries @ multi-select field with auto-complete
2 participants