Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for rule ideas! 💡 #1

Open
poenneby opened this issue Dec 18, 2016 · 9 comments
Open

Looking for rule ideas! 💡 #1

poenneby opened this issue Dec 18, 2016 · 9 comments

Comments

@poenneby
Copy link
Owner

poenneby commented Dec 18, 2016

This plugin is extremely simple as it currently only defines the globals in CodeceptJS.
Here are some ideas of rules:

  • prefer_page_objects - Prevent the use of I within Scenario
  • missing_feature - Scenarios without Feature function call
  • missing_generator - Use of yield within a Scenario while missing generator function * declaration

Feel free to suggest others!

@textbook
Copy link
Contributor

textbook commented Dec 19, 2018

Rules around skipped and focused tests would be useful - for example, being able to make a focused test a lint error. (Skipped tests actually already are a lint error if you have no-undef on, as xScenario isn't in the globals...)

@GabrielfLuchtenberg
Copy link

It would help us on CI if we have some rule like " no only on scenarios"

@poshaughnessy
Copy link

Could there be a rule for no .only on a Scenario? (https://codecept.io/basics#skipping)

We sometimes add this to scenarios during debugging, but would like to make sure it's not checked in.

@textbook
Copy link
Contributor

textbook commented Jun 18, 2019

@GLuchtenberg @poshaughnessy I've added #11 and #12 for skipped and exclusive tests, respectively.

@GabrielfLuchtenberg
Copy link

Thanks @textbook I'll check!

@Georgegriff
Copy link

Georgegriff commented Nov 19, 2019

One of my colleagues just put out a pr for no pause if this is something might be interested in: #16

@poenneby
Copy link
Owner Author

poenneby commented Nov 19, 2019 via email

@kapilpau
Copy link
Contributor

kapilpau commented Mar 9, 2020

We have been hit by .only in Data driven tests so extended no-exclusive-tests to check for that: #19 @poenneby

@danielrentz
Copy link

@poenneby I would like to see a rule no-todo-tests just like no-skipped-tests.
https://codecept.io/basics/#todo-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants