Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: no-skipped-tests #11

Merged
merged 6 commits into from
Jun 25, 2019
Merged

Conversation

textbook
Copy link
Contributor

Name and report based on the Mocha ESLint plugin's no-skipped-tests rule.

Can detect and fix both xScenario and Scenario.skip.

@poenneby
Copy link
Owner

Looking good!
I had to make a little modification to one of my commits (test reporting 😬). Could you please rebase with master and I will get this merged asap.
Thanks

@textbook
Copy link
Contributor Author

textbook commented Jun 24, 2019

I've updated both rule PRs, but Travis seems unable to install Node via NVM (due to an "Unknown SSL protocol error in connection to nodejs.org:443" or just hanging indefinitely). Up to you whether you want to merge anyway - all of the tests pass locally in 10.13.0.

Also FWIW I'm not sure that rewriting a commit that was part of a tagged release was a great idea - it certainly led to some confusion when I was trying to align everything!

@textbook textbook closed this Jun 24, 2019
@textbook textbook reopened this Jun 24, 2019
@poenneby
Copy link
Owner

Yes sorry about the headache caused although normally you'd only get one conflict in package.json? I also see you managed to fix the build 👌
Will get this merged and released asap.
Thanks again!

@poenneby poenneby merged commit 02fe337 into poenneby:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants