Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thoughts on this being an addon? #28

Closed
stefanpenner opened this issue Jun 28, 2014 · 8 comments
Closed

thoughts on this being an addon? #28

stefanpenner opened this issue Jun 28, 2014 · 8 comments

Comments

@stefanpenner
Copy link

it would be great to see if we can expose the appropriate hooks in ember-cli proper for this to merely be an addon.

@jakecraige
Copy link
Contributor

@stefanpenner I love the idea and it would certainly make my life easier..

Really all I would need is a way to add commands to it and I think it could be done. Instead of ember-cdv command it would be ember cdv-command

One potential problem which I don't know the answer too is adding these commands to it globally. The initial app structure setup I provide would require a global blueprint to use to set up a new project, everything else works in a generated project. With that being said, I may be able to reverse the structure of how I have it now to resolve this. Currently it's cordova folders with an ember one inside, If I could switch it to ember folders with a cordova one inside then you could generate an ember-cli project and run one of my commands after

I am currently planning on removing the bower install / npm install parts of this by switching those dependencies to cli addons which would help in this sort of transition

@jakecraige
Copy link
Contributor

@stefanpenner I've actually put some work into adding commands within an addon this morning and I'm making good progress. Could probably get a PR ready for ember-cli by the end of the weekend

@stefanpenner
Copy link
Author

@jakecraige im excited :)

@rwjblue
Copy link

rwjblue commented Jun 28, 2014

Sounds awesome!

@stefanpenner
Copy link
Author

@jakecraige if you are not already, feel free to pop by #ember-cli on freenode

@jakecraige
Copy link
Contributor

@stefanpenner I'm out of the house right now but i should've able to be on
this evening

On Saturday, June 28, 2014, Stefan Penner notifications@github.com wrote:

@jakecraige https://github.com/jakecraige if you are not already, feel
free to pop by #ember-cli on freenode


Reply to this email directly or view it on GitHub
#28 (comment)
.

Thanks,

Jake Craige
Poetic Systems
675 Bering Dr. Suite 725
Houston, TX 77057
(281) 531-4060 - Office

@jakecraige
Copy link
Contributor

Got the PR into ember-cli that will make this possible, ember-cli/ember-cli#1196

@stefanpenner
Copy link
Author

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants