Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need some help for contributing new losses. #93

Closed
abhinavsp0730 opened this issue Sep 24, 2020 · 2 comments
Closed

Need some help for contributing new losses. #93

abhinavsp0730 opened this issue Sep 24, 2020 · 2 comments

Comments

@abhinavsp0730
Copy link
Contributor

I'm trying to add a new loss MeanSquaredLogarithimcError in elegy. I've created the mean_squared_logarithmic_error.py
and also mean_squared_logarithmic_error_test.py. But while executing pytest, I'm getting error
AttributeError: module 'elegy.losses' has no attribute 'MeanSquaredLogarithmicError'
and
AttributeError: module 'elegy.losses' has no attribute 'mean_squared_logarithmic_error'
PS: I've also defined necessary imports in __init__.py .

Please see the attached image.
cc: @Davidnet @charlielito @cgarciae @haruiz
Screenshot_20200924_192606

@charlielito
Copy link
Collaborator

Hi @abhinavsp0730, thanks for contributing!
Would you mind making a PR so we can reproduce your issue?

@abhinavsp0730
Copy link
Contributor Author

Hi, I guess I was messed up with VS codes and poetry interpreter.
Thanks for your quick reply.
I've raised a PR #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants